Merge all core codegen into FBReactNativeSpec #43570
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55037569 |
Base commit: 2fcdab4 |
javache
force-pushed
the
export-D55037569
branch
from
e9aad73 to
6a85969
Compare
javache
added a commit
to javache/react-native
that referenced
this pull request
Mar 20, 2024
Summary: `rncore`, `FBReactNativeSpec` and `FBReactNativeComponentSpec` contain the same symbols, which leads to conflicts when we try to merge them into a single shared library. Cleanup the duplication and standardize on `FBReactNativeSpec` everywhere. I've left the Android OSS targets names as is, to avoid breaking deps. This aligns react-native's package.json with the codegen tooling supported across iOS and Android, which is a single target for all all type-derived codegen. Changelog: [Internal] Differential Revision: D55037569
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55037569 |
javache
force-pushed
the
export-D55037569
branch
from
6a85969 to
abafe11
Compare
javache
added a commit
to javache/react-native
that referenced
this pull request
Mar 22, 2024
Summary: `rncore`, `FBReactNativeSpec` and `FBReactNativeComponentSpec` contain the same symbols, which leads to conflicts when we try to merge them into a single shared library. Cleanup the duplication and standardize on `FBReactNativeSpec` everywhere. I've left the Android OSS targets names as is, to avoid breaking deps. This aligns react-native's package.json with the codegen tooling supported across iOS and Android, which is a single target for all all type-derived codegen. Changelog: [Internal] Differential Revision: D55037569
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55037569 |
javache
force-pushed
the
export-D55037569
branch
from
abafe11 to
5ef6166
Compare
javache
added a commit
to javache/react-native
that referenced
this pull request
Mar 25, 2024
Summary: `rncore`, `FBReactNativeSpec` and `FBReactNativeComponentSpec` contain the same symbols, which leads to conflicts when we try to merge them into a single shared library. Cleanup the duplication and standardize on `FBReactNativeSpec` everywhere. I've left the Android OSS targets names as is, to avoid breaking deps. This aligns react-native's package.json with the codegen tooling supported across iOS and Android, which is a single target for all all type-derived codegen. Changelog: [Internal] Differential Revision: D55037569
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55037569 |
javache
added a commit
to javache/react-native
that referenced
this pull request
Mar 27, 2024
Summary: `rncore`, `FBReactNativeSpec` and `FBReactNativeComponentSpec` contain the same symbols, which leads to conflicts when we try to merge them into a single shared library. Cleanup the duplication and standardize on `FBReactNativeSpec` everywhere. I've left the Android OSS targets names as is, to avoid breaking deps. This aligns react-native's package.json with the codegen tooling supported across iOS and Android, which is a single target for all all type-derived codegen. Changelog: [Internal] Differential Revision: D55037569
javache
force-pushed
the
export-D55037569
branch
from
5ef6166 to
7647e27
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55037569 |
javache
force-pushed
the
export-D55037569
branch
from
7647e27 to
44938dc
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55037569 |
javache
added a commit
to javache/react-native
that referenced
this pull request
Apr 5, 2024
Summary: Pull Request resolved: facebook#43570 `rncore`, `FBReactNativeSpec` and `FBReactNativeComponentSpec` contain the same symbols, which leads to conflicts when we try to merge them into a single shared library. Cleanup the duplication and standardize on `FBReactNativeSpec` everywhere. I've left the Android OSS targets names as is, to avoid breaking deps. This aligns react-native's package.json with the codegen tooling supported across iOS and Android, which is a single target for all all type-derived codegen. Changelog: [Internal] Differential Revision: D55037569
javache
added a commit
to javache/react-native
that referenced
this pull request
Apr 5, 2024
Summary: Pull Request resolved: facebook#43570 `rncore`, `FBReactNativeSpec` and `FBReactNativeComponentSpec` contain the same symbols, which leads to conflicts when we try to merge them into a single shared library. Cleanup the duplication and standardize on `FBReactNativeSpec` everywhere. I've left the Android OSS targets names as is, to avoid breaking deps. This aligns react-native's package.json with the codegen tooling supported across iOS and Android, which is a single target for all all type-derived codegen. Changelog: [Internal] Differential Revision: D55037569
javache
force-pushed
the
export-D55037569
branch
from
44938dc to
a1171a7
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55037569 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55037569 |
javache
added a commit
to javache/react-native
that referenced
this pull request
Apr 5, 2024
Summary: Pull Request resolved: facebook#43570 `rncore`, `FBReactNativeSpec` and `FBReactNativeComponentSpec` contain the same symbols, which leads to conflicts when we try to merge them into a single shared library. Cleanup the duplication and standardize on `FBReactNativeSpec` everywhere. I've left the Android OSS targets names as is, to avoid breaking deps. This aligns react-native's package.json with the codegen tooling supported across iOS and Android, which is a single target for all all type-derived codegen. Changelog: [Internal] Differential Revision: D55037569
javache
force-pushed
the
export-D55037569
branch
from
a1171a7 to
883ae5f
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55037569 |
javache
force-pushed
the
export-D55037569
branch
from
883ae5f to
2f75d77
Compare
javache
added a commit
to javache/react-native
that referenced
this pull request
Apr 5, 2024
Summary: Pull Request resolved: facebook#43570 `rncore`, `FBReactNativeSpec` and `FBReactNativeComponentSpec` contain the same symbols, which leads to conflicts when we try to merge them into a single shared library. Cleanup the duplication and standardize on `FBReactNativeSpec` everywhere. I've left the Android OSS targets names as is, to avoid breaking deps. This aligns react-native's package.json with the codegen tooling supported across iOS and Android, which is a single target for all all type-derived codegen. Changelog: [Internal] Differential Revision: D55037569
javache
added a commit
to javache/react-native
that referenced
this pull request
Apr 5, 2024
Summary: Pull Request resolved: facebook#43570 `rncore`, `FBReactNativeSpec` and `FBReactNativeComponentSpec` contain the same symbols, which leads to conflicts when we try to merge them into a single shared library. Cleanup the duplication and standardize on `FBReactNativeSpec` everywhere. I've left the Android OSS targets names as is, to avoid breaking deps. This aligns react-native's package.json with the codegen tooling supported across iOS and Android, which is a single target for all all type-derived codegen. Changelog: [Internal] Differential Revision: D55037569
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55037569 |
javache
force-pushed
the
export-D55037569
branch
2 times, most recently
from
53a7c30 to
4bf6bfd
Compare
javache
added a commit
to javache/react-native
that referenced
this pull request
Apr 5, 2024
Summary: Pull Request resolved: facebook#43570 `rncore`, `FBReactNativeSpec` and `FBReactNativeComponentSpec` contain the same symbols, which leads to conflicts when we try to merge them into a single shared library. Cleanup the duplication and standardize on `FBReactNativeSpec` everywhere. I've left the Android OSS targets names as is, to avoid breaking deps. This aligns react-native's package.json with the codegen tooling supported across iOS and Android, which is a single target for all all type-derived codegen. Changelog: [Internal] Differential Revision: D55037569
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55037569 |
Summary: Pull Request resolved: facebook#43570 `rncore`, `FBReactNativeSpec` and `FBReactNativeComponentSpec` contain the same symbols, which leads to conflicts when we try to merge them into a single shared library. Cleanup the duplication and standardize on `FBReactNativeSpec` everywhere. I've left the Android OSS targets names as is, to avoid breaking deps. This aligns react-native's package.json with the codegen tooling supported across iOS and Android, which is a single target for all all type-derived codegen. Changelog: [Internal] Differential Revision: D55037569
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55037569 |
javache
force-pushed
the
export-D55037569
branch
from
4bf6bfd to
93e0796
Compare
Collaborator
|
This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
react-native-bot
added
the
Stale
Collaborator
|
This PR was closed because it has been stalled for 7 days with no activity. |
react-native-bot
removed
the
Stale
javache
added a commit
to javache/react-native
that referenced
this pull request
Mar 27, 2025
Summary: Pull Request resolved: facebook#43570 `rncore`, `FBReactNativeSpec` and `FBReactNativeComponentSpec` contain the same symbols, which leads to conflicts when we try to merge them into a single shared library. Cleanup the duplication and standardize on `FBReactNativeSpec` everywhere. I've left the Android OSS targets names as is, to avoid breaking deps. This aligns react-native's package.json with the codegen tooling supported across iOS and Android, which is a single target for all all type-derived codegen. Changelog: [Internal] Differential Revision: D55037569
javache
added a commit
to javache/react-native
that referenced
this pull request
Mar 27, 2025
Summary: Pull Request resolved: facebook#50317 Pull Request resolved: facebook#43570 `rncore`, `FBReactNativeSpec` and `FBReactNativeComponentSpec` contain the same symbols, which leads to conflicts when we try to merge them into a single shared library. Cleanup the duplication and standardize on `FBReactNativeSpec` everywhere. I've left the Android OSS targets names as is, to avoid breaking deps. This aligns react-native's package.json with the codegen tooling supported across iOS and Android, which is a single target for all all type-derived codegen. Changelog: [Internal] Differential Revision: D55037569
javache
added a commit
to javache/react-native
that referenced
this pull request
Mar 27, 2025
Summary: Pull Request resolved: facebook#50317 Pull Request resolved: facebook#43570 `rncore`, `FBReactNativeSpec` and `FBReactNativeComponentSpec` contain the same symbols, which leads to conflicts when we try to merge them into a single shared library. Cleanup the duplication and standardize on `FBReactNativeSpec` everywhere. I've left the Android OSS targets names as is, to avoid breaking deps. This aligns react-native's package.json with the codegen tooling supported across iOS and Android, which is a single target for all all type-derived codegen. Changelog: [Internal] Differential Revision: D55037569
javache
added a commit
to javache/react-native
that referenced
this pull request
May 30, 2025
Summary: Pull Request resolved: facebook#43570 `rncore`, `FBReactNativeSpec` and `FBReactNativeComponentSpec` contain the same symbols, which leads to conflicts when we try to merge them into a single shared library. Cleanup the duplication and standardize on `FBReactNativeSpec` everywhere. I've left the Android OSS targets names as is, to avoid breaking deps. This aligns react-native's package.json with the codegen tooling supported across iOS and Android, which is a single target for all all type-derived codegen. Changelog: [Internal] Differential Revision: D55037569
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
rncore,FBReactNativeSpecandFBReactNativeComponentSpeccontain the same symbols, which leads to conflicts when we try to merge them into a single shared library. Cleanup the duplication and standardize onFBReactNativeSpeceverywhere. I've left the Android OSS targets names as is, to avoid breaking deps.This aligns react-native's package.json with the codegen tooling supported across iOS and Android, which is a single target for all all type-derived codegen.
Changelog: [Internal]
Differential Revision: D55037569